Move provider branches and default runtime behind

Task 9030 · Done · Coder · created · updated

Follow-up from Task 9007, which widened the vendor census (`tools/tests/test_vendor_name_census.py`) to every provider name and recorded, without justifying, two kinds of leftover: 1. `VENDOR_CONTEXT["branch-debt"]`: real branches on a provider value outside the seam. Move each onto a catalogue capability (`apps/jaahd/agent_providers.py`) or the provider's adapter, then delete its row: - apps/api: compliance_manifest.py (agent-kind label dict), hipaa.py (provider-keyed surface map), live_cast/evaluate.py, operator_dashboard/review.py, support_kb/lessons.py (`if provider == llm_client.ANTHROPIC`), pr_review/verdict.py (vendor-keyed tier table), playbook_prompt.py, support_kb/doctrine.py, routes/personas.py (the charter provider literal), routes/accounts.py (`provider: str = "claude"` default), routes/tasks/activity.py (`AGENT_KIND_CLAUDE_CODE` branch), seed_dev_profile.py. - apps/web: lib/sessionLink.ts (`engine === 'claude_code'`), pages/credentials/accountModel.tsx (`CLAUDE_PROVIDER`), AccountEditPage.tsx and Accounts.tsx (`isClaudeProvider`). 2. `DEFAULT_RUNTIME_DEBT`: lines naming the default provider's legacy runtime in orchestration modules (collector.py's token ladder, reconcile/accounts_probe.py's `claude agents` probe, session_sweep.py's transcript fold, fleet_dispatch.py's launch env, lease_drain.py's `CLAUDE_CONFIG_DIR` contract, dispatch_compose comments). Move them behind `agents/claude.py` or the catalogue and lower each count. Out of scope: renaming DB columns, verbs, MCP names (ADR-0166); changing operator-facing copy or runner prompt bytes; changing accepted credential shapes. Done means: the branch-debt category is empty (or each remaining row has a reason it cannot move); every lowered `DEFAULT_RUNTIME_DEBT` count matches the tree; `python3 -m pytest -q tools/tests/test_vendor_name_census.py` green; existing tests for each moved site pass unchanged; `./dc check quick` green.

Outcome

Branch-debt category emptied (16 sites moved onto llm_client/agent_sessions/agent_providers/providerCatalogue); DEFAULT_RUNTIME_DEBT 170→15, the rest justified. Quick gate green; PR #6660 queued to the lane. Memory: none applied.

Pull request

Artifacts

Activity

  • Created
  • Run
  • Runner started
  • Runner ended (done)