GCP and Azure node and NodeLink pages show

Task 8882 · Done · Coder · created · updated

Found by the Dev oracle run (Task 8781, report artifact 8129) with a GCP Your Cloud node (e2-standard-2, us-central1). Supersedes draft #8878. Observed and cause: 1. Host page says "Cloud (EC2)" for a GCP node — apps/web/src/pages/nodes/hosts/hostFacts.tsx:275 hardcodes the label. 2. "EC2" and "Connect (SSM)" links open *.console.aws.amazon.com for a GCP instance — apps/web/src/components/CloudInstanceFacts.tsx:32-33; render sites apps/web/src/pages/NodeDetailPage.tsx:1490-1492 and apps/web/src/pages/nodes/hosts/HostDetailPage.tsx:578 gate only on operator + instance_id, never on the node's cloud provider (clouds.INFRA_PROVIDER_KEY "cloud_provider", not infra.provider — see mem-23019). 3. GCP machine panel shows Disk "Unknown" right after launch though the disk is 60 GB. 4. Grow disk dialog pre-fills "1" GB. 5. NodeLink storage rows for a Filestore read "Mount target / Access point / Policy" — apps/web/src/pages/nodes/nodeLinkStore/NodeLinkStorageTab.tsx:333,350,365,389,418. 6. Add node offers failed NodeLinks and other-cloud NodeLinks — apps/web/src/components/NodeLinkPicker.tsx:23 filters only status !== 'deleting'. 7. NodeLink Delete says "files stay on your Filestore, which is still billed" when no Filestore was ever created. Requirements: - Label the machine by its provider ("Cloud (GCP)", "Cloud (Azure)", "Cloud (EC2)"). - Console links per provider (GCP Compute instance page; Azure portal VM page) or none; never an AWS URL for a non-AWS node. - Record disk size at launch for GCP/Azure so the panel shows it. - Grow disk pre-fills current size + a step and shows the current size. - NodeLink storage rows use the storage provider's terms, hiding EFS-only rows on Filestore/Azure Files. - Add node offers only ready NodeLinks whose storage is on the same cloud as the chosen connection (the server already refuses cross-cloud with 409). - The Delete dialog's "still billed" sentence appears only when the storage exists. Out of scope: lifecycle behaviour (stop/start/type/disk all worked), API adapters, Jaah Hosted. Done means: - Screenshots on dev (1280 and 390 wide) of a GCP node's host page, Grow disk dialog, a Filestore NodeLink detail and the Add node NodeLink list show provider-correct wording and links; an AWS node page is unchanged. - Vitest covers the per-provider label/link choice and the NodeLink picker filter; quick gate green.

Outcome

GCP/Azure pages now use provider labels, console links, disk at launch, Grow disk pre-fill, Filestore terms, a same-cloud ready-only NodeLink picker and honest Delete wording. Quick gate green; PR #6590 merged (a02bfd4); its deploy was superseded. Follow-up draft #8893. Memory: none applied.

Pull request

Artifacts

Activity

  • Ready
  • Runner started
  • Runner ended (done)